davide
/
ELAB-partsearch
1
0
Fork 0
Code Issues 4 Pull Requests Releases Wiki Activity
Labels Milestones
New Issue

Closing the result overlay doesn't delete "p=<partnumber>" from the URL #5

Closed
opened 2 years ago by davide · 1 comments
davide commented 2 years ago
Owner

Steps to reproduce

  • Perform a search in the search engine
  • Click on a result
  • Observe that the URL is now https://www.elab.kth.se/parts?q=<query>&p=<partnumber>
  • Close the overlay
  • Observe that the URL didn't change

Expected behavior

When the overlay is closed, the URL should go back to only contain the query, so that copy pasting it brings to the same view as the user who copied it.

# Steps to reproduce - Perform a search in the search engine - Click on a result - Observe that the URL is now `https://www.elab.kth.se/parts?q=<query>&p=<partnumber>` - Close the overlay - Observe that the URL didn't change # Expected behavior When the overlay is closed, the URL should go back to only contain the query, so that copy pasting it brings to the same view as the user who copied it.
marek commented 2 years ago
Owner

BOOM FIXED

BOOM FIXED
davide closed this issue 2 years ago
davide reopened this issue 2 years ago
davide closed this issue 2 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
map-with-names
fix-empty-location
fix-creating-users
missing-part-reporting
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: davide/ELAB-partsearch#5
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes